Skip to content

feat: update component command to return proper json result @W-19036340 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: update component command to return proper json result @W-19036340 #459

wants to merge 8 commits into from
+114 −49

Conversation

nrkruk
Copy link
Collaborator

@nrkruk nrkruk commented Jul 18, 2025

What does this PR do?

  • Update component command to use api-version
  • Component command now returns json
  • Passing back json will allow easier integration with VSCode for the near term until we decide on how best to use a shared library across both CLI and VSCode

What issues does this PR fix or reference?

@W-19036340@

@nrkruk nrkruk self-assigned this Jul 18, 2025
@nrkruk nrkruk added the nomerge Do not merge this PR until label is removed by the author. label Jul 18, 2025
@nrkruk nrkruk requested review from a team as code owners July 18, 2025 04:19
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result feat: update component command to use api-version / return proper json result @W-19036340 Jul 18, 2025
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result @W-19036340 feat: update component command to return proper json result @W-19036340 Jul 18, 2025
maliroteh-sf
maliroteh-sf approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@maliroteh-sf maliroteh-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliroteh-sf maliroteh-sf maliroteh-sf approved these changes

Assignees

@nrkruk nrkruk

Labels
nomerge Do not merge this PR until label is removed by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrkruk @maliroteh-sf @svc-cli-bot